netdev - Re: [PATCH 01/21] [next] qlge: Change to device ID 8000 and corresponding flash access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232753339.3005.6.camel@achroite>
Date:	Fri, 23 Jan 2009 23:28:59 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Ron Mercer <ron.mercer@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-driver@...gic.com
Subject: Re: [PATCH 01/21] [next] qlge: Change to device ID 8000 and
	corresponding flash access.

On Fri, 2009-01-23 at 07:16 -0800, Ron Mercer wrote:
[...]
> diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
> index 16eb9dd..a530f5b 100644
> --- a/drivers/net/qlge/qlge_main.c
> +++ b/drivers/net/qlge/qlge_main.c
[...]
> @@ -657,28 +680,38 @@ static int ql_read_flash_word(struct ql_adapter *qdev, int offset, u32 *data)
>  	if (status)
>  		goto exit;
>  	/* get the data */
> -	*data = ql_read32(qdev, FLASH_DATA);
> +	*data = cpu_to_le32(ql_read32(qdev, FLASH_DATA));
[...]

Should be le32_to_cpu not cpu_to_le32.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html