netdev - Re: [PATCH 10/34]bnx2x: Compilation issue on IA64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090125.181626.229897179.davem@davemloft.net>
Date:	Sun, 25 Jan 2009 18:16:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH 10/34]bnx2x: Compilation issue on IA64

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Fri, 23 Jan 2009 10:42:27 +0200

> On Wed, 2009-01-14 at 13:10 -0800, David Miller wrote:
> > From: "Eilon Greenstein" <eilong@...adcom.com>
> > Date: Wed, 14 Jan 2009 19:44:33 +0200
> > 
> > > On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> > > > On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > > > > Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> > > [...]  
> > > > >  #ifdef BNX2X_STOP_ON_ERROR
> > > > >  	fp->tpa_queue_used |= (1 << queue);
> > > > > -#ifdef __powerpc64__
> > > > > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > > > >  	DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > > > >  #else
> > > > >  	DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
> > > > 
> > > > Or you could cast the value to unsigned long long and remove this
> > > > fragile #ifdef.
> > > > 
> > > You are right - it is a better solution. The issue is that this uglier
> > > solution is already in, and I hate to re-send this patch just for this.
> > > Can we have this one applied and I will re visit it in net-next?
> > 
> > There is no reason to crap up any driver with arch ifdefs, absolutely
> > none, for this typing issue.
> > 
> > The whole point is that we're trying to get all of the arch's to use
> > the same type for u64 in the kernel, so that these warnings can be
> > cleared away very easily.
> > 
> > Live with the warnings meanwhile until this is all sorted out.
> 
> I can live with that, but I was wondering if this change is something
> that you can consider:
> -#ifdef __powerpc64__
> +#ifdef _ASM_GENERIC_INT_L64_H
> 
> My problem is that in the mean time, the driver has this __powerpc64__
> ifdef in it.

Just use %ll unconditionally and cast the argument to
long long.  Then you don't need any ifdefs at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html