netdev - Re: [PANIC] lro + iscsi or lro + skb text search causes panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090125.213436.268287293.davem@davemloft.net>
Date:	Sun, 25 Jan 2009 21:34:36 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	michaelc@...wisc.edu
Cc:	jesse.brandeburg@...el.com, netdev@...r.kernel.org,
	olaf.kirch@...cle.com, tgraf@...g.ch, kkeil@...e.de,
	herbert@...dor.apana.org.au
Subject: Re: [PANIC] lro + iscsi or lro + skb text search causes panic

From: Mike Christie <michaelc@...wisc.edu>
Date: Thu, 22 Jan 2009 22:22:42 -0600

> Attached is a patch made against the scsi maintainer's tree (I think
> it should also apply to linus's) that converts iscsi to use
> skb_copy_bits. It is lightly tested. If there is no benefit in
> having skb_find_text use skb_seq_read maybe we can just kill it, so
> people do not have to maintain two helpers that provide similar
> functionality.

Regardless of what we decide to do with iSCSI we have to make this
function work properly as long as there is a user in the tree.

This iterator can in fact be more efficient than using copy
bits since copy bits doesn't remember any state from previous
invocations whereas the iterator does.  So if you call it
multiple times on the same SKB that's a lot of wasted work.

In fact I'm pretty sure that's why we added it for textsearch,
because in that application we're constantly beating through
the same SKB via the testsearch state machine.

Therefore, keeping it's use for iSCSI would be beneficial.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html