netdev - Re: [PATCH] net: fix setsockopt() locking errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090126.123351.201148059.davem@davemloft.net>
Date:	Mon, 26 Jan 2009 12:33:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	vegard.nossum@...il.com, mmokrejs@...osome.natur.cuni.cz,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix setsockopt() locking errors

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 26 Jan 2009 11:50:12 +0000

> On 24-01-2009 23:49, Vegard Nossum wrote:
> > +static int sock_linger(struct sock *sk, char __user *optval, int optlen)
> ...
> > +static int sock_set_rcvtimeo(struct sock *sk, char __user *optval, int optlen)
> > +{
> > +	int ret;
> > +	long rcvtimeo;
> > +
> > +	ret = sock_set_timeout(&rcvtimeo, optval, optlen);
> 
> A check for error is needed here and below.

Right, you cannot continue and update the socket state if this
sock_set_timeout() call returns an error.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html