netdev - Re: [PATCH]bnx2x: tx_has_work should not wait for FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Jan 2009 12:36:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	netdev@...r.kernel.org, vladz@...adcom.com
Subject: Re: [PATCH]bnx2x: tx_has_work should not wait for FW

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Mon, 26 Jan 2009 18:55:56 +0200

> The current tx_has_work waited until all packets sent by the driver are marked
> as completed by the FW. This is too greedy and it causes the bnx2x_poll to spin
> in vain. The driver should only check that all packets FW already completed are
> freed - only in unload flow the driver should make sure that transmit queue is
> empty
> 
> Signed-off-by: Vladislav Zolotarov <vladz@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html