netdev - Re: [PATCH] net: fix setsockopt() locking errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19f34abd0901270825j570037b8k3629764d3a09e661@mail.gmail.com>
Date:	Tue, 27 Jan 2009 17:25:12 +0100
From:	Vegard Nossum <vegard.nossum@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	jarkao2@...il.com, mmokrejs@...osome.natur.cuni.cz,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix setsockopt() locking errors

On Mon, Jan 26, 2009 at 9:33 PM, David Miller <davem@...emloft.net> wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Mon, 26 Jan 2009 11:50:12 +0000
>
>> On 24-01-2009 23:49, Vegard Nossum wrote:
>> > +static int sock_linger(struct sock *sk, char __user *optval, int optlen)
>> ...
>> > +static int sock_set_rcvtimeo(struct sock *sk, char __user *optval, int optlen)
>> > +{
>> > +   int ret;
>> > +   long rcvtimeo;
>> > +
>> > +   ret = sock_set_timeout(&rcvtimeo, optval, optlen);
>>
>> A check for error is needed here and below.
>
> Right, you cannot continue and update the socket state if this
> sock_set_timeout() call returns an error.
>

Argh, thanks both. What a stupid mistake. What is the point in fixing
something if the fix introduces a different kind of error? :-(

I will fix the patch and also check for other places (like that
attach_filter) that need to be fixed.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html