netdev - [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090127032028.26631.27015.stgit@lost.foo-projects.org>
Date:	Mon, 26 Jan 2009 19:20:28 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org, davem@...emloft.net, jeff@...zik.org,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using
	it.

From: Alexander Duyck <alexander.h.duyck@...el.com>

A bug was found in which the memory for the tc_skbedit struct was being
used uninitialized to 0.  This patch corrects the issue by using a memset
to 0 out the memory of the structure.

Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---

 tc/m_skbedit.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 55e3f89..0e50fbc 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -57,6 +57,8 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 	__u16 queue_mapping;
 	__u32 flags = 0, priority;
 
+	memset(&sel, 0, sizeof(struct tc_skbedit));
+
 	if (matches(*argv, "skbedit") != 0)
 		return -1;
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html