netdev - RE: [PANIC] lro + iscsi or lro + skb text search causes panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A1C225135@orsmsx507.amr.corp.intel.com>
Date:	Mon, 26 Jan 2009 17:40:08 -0800
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	David Miller <davem@...emloft.net>
CC:	"michaelc@...wisc.edu" <michaelc@...wisc.edu>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tgraf@...g.ch" <tgraf@...g.ch>, "kkeil@...e.de" <kkeil@...e.de>
Subject: RE: [PANIC] lro + iscsi or lro + skb text search causes panic

Herbert Xu wrote:
> On Sun, Jan 25, 2009 at 09:32:22PM -0800, David Miller wrote:
>> From: Mike Christie <michaelc@...wisc.edu>
>> Date: Thu, 22 Jan 2009 18:04:11 -0600
>> 
>>> With the patch running against linus's git tree, my box locks
>>> up. You cannot ping it. I do not get a oops or anything in the logs,
>>> and the keyboard does not respond. I will try to get some oops
>>> output and more info.
>> 
>> Herbert, any idea offhand?
> 
> Yeah, I missed an offset update in there :) Here's a better version.
> 
> net: Fix frag_list handling in skb_seq_read
> 
> The frag_list handling was broken in skb_seq_read:
> 
> 1) We didn't add the stepped offset when looking at the head
> are of fragments other than the first.
> 
> 2) We didn't take the stepped offset away when setting the data
> pointer in the head area.
> 
> 3) The frag index wasn't reset.
> 
> This patch fixes both issues.

1-3 (both, :-)) doesn't seem to work here, I applied this and still got a 
panic when doing a quick test before I went home today.

I can get panic trace from netconsole tomorrow.--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html