netdev - Re: [PATCH 02/21] RDS: Main header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901270934.16669.remi.denis-courmont@nokia.com>
Date:	Tue, 27 Jan 2009 09:34:16 +0200
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext Andy Grover" <andy.grover@...cle.com>
Cc:	rdreier@...co.com, rds-devel@....oracle.com,
	general@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [PATCH 02/21] RDS: Main header file

On Tuesday 27 January 2009 04:17:39 ext Andy Grover, you wrote:
> +/*
> + * XXX randomly chosen, but at least seems to be unused:
> + * #               18464-18768 Unassigned
> + * We should do better.  We want a reserved port to discourage unpriv'ed
> + * userspace from listening.
> + */
> +#define RDS_PORT	18634

Internet transport protocol port number? IANA has a process for assigning port 
numbers to proprietary protocols.

Not that I'd blame you, as I inherited VLC media player's wide abuse of port 
1234 as its current network core maintainer :(

> +#ifndef AF_RDS
> +#define AF_RDS          28      /* Reliable Datagram Socket     */
> +#endif
> +
> +#ifndef PF_RDS
> +#define PF_RDS          AF_RDS
> +#endif

You should probably remove that and put the last patch of your series ahead of 
this one.

> +#ifndef SOL_RDS
> +#define SOL_RDS         272
> +#endif

This is used by RXRPC nowadays, although I myself don't really understand why 
socket option levels need to be unique across all families.

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html