netdev - Re: [PATCH] net: wrong test in inet_ehash_locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090127.174519.136722631.davem@davemloft.net>
Date:	Tue, 27 Jan 2009 17:45:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: wrong test in inet_ehash_locks_alloc()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 27 Jan 2009 15:42:14 +0100

> In commit 9db66bdcc83749affe61c61eb8ff3cf08f42afec
> (net: convert TCP/DCCP ehash rwlocks to spinlocks), I forgot to change
>  one occurrence of rwlock_t to spinlock_t
> 
> I believe sizeof(raw_spinlock_t) might be > 0 on !CONFIG_SMP if CONFIG_DEBUG_SPINLOCK
> while sizeof(raw_rwlock_t) should be 0 in this case.
> 
> Fortunatly, CONFIG_DEBUG_SPINLOCK adds fields to both spinlock_t and rwlock_t,
> but at this might change in the future (being able to debug spinlocks but not rwlocks for
> example), better to be safe.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Agreed, applied.

Thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html