netdev - Re: [PATCH] Fix infinite retry loop in IP-Config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090128105220.GB4190@ff.dom.local>
Date:	Wed, 28 Jan 2009 10:52:21 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Benjamin ZORES <benjamin.zores@...atel-lucent.fr>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix infinite retry loop in IP-Config

On 28-01-2009 10:07, Benjamin ZORES wrote:
> Hi,
> 
> The attached patch fixes some bug with ip-config max retry number.
> In ip_auto_config(), kernel tries to retrieve IP configuration forever
> in case of NFS root and some specific amount of time otherwise.
> 
> The problem is that, in case of error, the code jump to the try_try_again
> goto statement, that reassigns the retry number counter, which obviously
> leads to an infinite loop if IP config fails.
> 
> The attached patch corrects this behavior.
> Hope one can push it to mainstream kernel tree.
> 
> Ben
> 
> diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
> index 42a0f3d..4911b81 100644
> --- a/net/ipv4/ipconfig.c
> +++ b/net/ipv4/ipconfig.c
> @@ -1268,6 +1268,7 @@ __be32 __init root_nfs_parse_addr(char *name)
>  static int __init ip_auto_config(void)
>  {
>  	__be32 addr;
> +	 int retries = CONF_OPEN_RETRIES;
 
Doesn't it need "#ifdef IPCONFIG_DYNAMIC" to prevent a compiler
warning? I guess you could add a "Signed-off-by:" line BTW.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html