netdev - Re: [PATCH 1/1] smsc9420: fix interrupt signalling test failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090129.172923.24519684.davem@davemloft.net>
Date:	Thu, 29 Jan 2009 17:29:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	steve.glendinning@...c.com
Cc:	netdev@...r.kernel.org, ian.saturley@...c.com
Subject: Re: [PATCH 1/1] smsc9420: fix interrupt signalling test failures

From: Steve Glendinning <steve.glendinning@...c.com>
Date: Thu, 29 Jan 2009 16:39:23 +0000

> smsc9420 performs an interrupt signalling test when the interface is
> brought up.  The current code mistakenly sets its test flag to false
> AFTER enabling the software interrupt source, making failure quite
> likely.
> 
> This patch changes the code to set the test flag BEFORE enabling
> interrupts. I've also removed an smp_wmb because the following spinlock
> provides an implicit memory barrier.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>

Applied, thanks Steve.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html