netdev - Re: [ofa-general] NetEffect, iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1233303762.26509.15.camel@lb-tlvb-eliezer>
Date:	Fri, 30 Jan 2009 10:22:42 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Herbert Xu" <herbert@...dor.apana.org.au>
cc:	"Roland Dreier" <rdreier@...co.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"aluno3@...zta.onet.pl" <aluno3@...zta.onet.pl>,
	"general@...ts.openfabrics.org" <general@...ts.openfabrics.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [ofa-general] NetEffect, iw_nes and kernel warning

On Thu, 2009-01-29 at 22:57 -0800, Herbert Xu wrote:
> Roland Dreier <rdreier@...co.com> wrote:
> > 
> > OK, thanks... what confused me is that several other drivers also do
> > skb_linearize() in their hard_start_xmit method... eg bnx2x,
> > via-velocity, mv643xx_eth.  So there are several other lurking bugs to
> > deal with here I guess.
> 
> I don't know about the rest but bnx2x is certainly OK since it
> only does so with IRQ enabled.  It is legal to call skb_linearize
> as long as you're sure that IRQs are enabled, which is always the
> case for hard_start_xmit upon entry.
> 
> So the only time you can't call it in hard_start_xmit is if you've
> just disabled IRQs yourself.
> 
Thanks Herbert,

That was my conclusion too and even though I was still looking at it
since this report yesterday - it still looks OK to me. The bnx2x is
getting into this flow when using SAMBA and it was tested on few systems
for days under traffic - this does not mean that the code is right and
it is not a prove that there is no bug - but it makes me feel better...

I would appreciate some comments if someone still thinks this is a bug.

Thanks,
Eilon


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html