[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090129.161929.241520668.davem@davemloft.net>
Date: Thu, 29 Jan 2009 16:19:29 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: benjamin.zores@...atel-lucent.fr
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] Fix infinite retry loop in IP-Config
From: Benjamin ZORES <benjamin.zores@...atel-lucent.fr>
Date: Wed, 28 Jan 2009 13:08:15 +0100
> Jarek Poplawski a écrit :
> > On 28-01-2009 10:07, Benjamin ZORES wrote:
> >
> >> diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
> >> index 42a0f3d..4911b81 100644
> >> --- a/net/ipv4/ipconfig.c
> >> +++ b/net/ipv4/ipconfig.c
> >> @@ -1268,6 +1268,7 @@ __be32 __init root_nfs_parse_addr(char *name)
> >> static int __init ip_auto_config(void)
> >> {
> >> __be32 addr;
> >> + int retries = CONF_OPEN_RETRIES;
> >>
> > Doesn't it need "#ifdef IPCONFIG_DYNAMIC" to prevent a compiler
> > warning? I guess you could add a "Signed-off-by:" line BTW.
> >
> You're perfectly right about this.
> Attached an updated version of the patch.
Patch applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists