netdev - Re: gro: Fix handling of imprecisely split packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090201.012510.119374504.davem@davemloft.net>
Date:	Sun, 01 Feb 2009 01:25:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: gro: Fix handling of imprecisely split packets

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 31 Jan 2009 23:49:49 -0800

> On Sat, Jan 31, 2009 at 11:01 PM, Herbert Xu
> <herbert@...dor.apana.org.au> wrote:
> > Hi Jeff:
> >
> > Please let me know if the ixgbe problems persist with this patch
> > against net-next.
> >
> > gro: Fix handling of imprecisely split packets
> >
> > The commit 89a1b249edcf9be884e71f92df84d48355c576aa (gro: Avoid
> > copying headers of unmerged packets) only worked for packets
> > which are either completely linear, completely non-linear, or
> > packets which exactly split at the boundary between headers and
> > payload.
> >
> > Anything else would cause bits in the header to go missing if
> > the packet is held by GRO.
> >
> > This may have broken drivers such as ixgbe.
> >
> > This patch fixes the places that assumed or only worked with
> > the above cases.
> >
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> >
> 
> Thanks Herbert!
> 
> I have applied the patch and hopefully I will have more information to
> you soon.  At the very least, I should have updated information for
> you on Monday.

Meanwhile I'll toss Herbert's patch into net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html