netdev - Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 10:07:42 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Denys Fedoryschenko <denys@...p.net.lb>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation
 with hrtimers

On Mon, 2 Feb 2009 19:26:17 +0200
Denys Fedoryschenko <denys@...p.net.lb> wrote:

> ------------->
> iproute2 : invalid burst/cburst calculation with hrtimers
> 
> If hrtimers on, /proc/net/psched shows 4th variable 
> as 1000000000
> Because burst calculated by division rate to this variable, 
> it will be almost always zero. As result, we will get higher system 
> load on low rates, and on high rates shaper will not able to process 
> data. So it is kind of critical bugfix for systems with hrtimers.
> It is checked and proved. Core 2 Quad was not able to 
> shape 200Mbps, and gave only 180-190. It is more safe to set it 
> to 1000HZ. If user wants, he can set custom "env" HZ variable.
> 
> Signed-off-by: Denys Fedoryschenko <denys@...p.net.lb>
> ---
> 
> -------------------------------------------------------

I would rather this be converted to floating point.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html