lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Feb 2009 20:10:54 +1030 From: Rusty Russell <rusty@...tcorp.com.au> To: Alex Williamson <alex.williamson@...com> Cc: markmc@...hat.com, netdev@...r.kernel.org, kvm@...r.kernel.org Subject: Re: [PATCH v3 1/4] virtio_net: Add a virtqueue for outbound control commands On Monday 02 February 2009 06:35:10 Alex Williamson wrote: > +static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, > + struct scatterlist data[], int out, int in) > +{ > + struct scatterlist sg[VIRTIO_NET_MAX_CTRL_ARGS]; ... > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > index f76bd4a..f28a72a 100644 > --- a/include/linux/virtio_net.h > +++ b/include/linux/virtio_net.h ... > +#define VIRTIO_NET_MAX_CTRL_ARGS 2 I think this definition belongs at the top of virtio_net.c; the others are userspace-exposed, this is really an internal issue, no? Other than that, you can add Acked-by: Rusty Russell <rusty@...tcorp.com.au> and send to netdev for DaveM's tree. Thanks! Rusty. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists