netdev - Re: qlge packet receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Feb 2009 08:08:15 -0800
From:	Ron Mercer <ron.mercer@...gic.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: qlge packet receive

On Mon, Feb 02, 2009 at 02:01:15PM -0800, David Miller wrote:
> 
> I wanted to mention a bug that I noticed in the qlge driver
> while perusing NAPI capable drivers last week.
> 
> Although qlge uses NAPI polling, it passes packets into the
> stack using netif_rx() and vlan_hwaccel_rx().
> 
> That's wrong and incredibly inefficient, because these routines
> are for the cases where the driver receives packets in hardware
> interrupt context, so they schedule a new software interrupt to
> process the frames.
> 
> NAPI ->poll() executes in software interrupt context so you can
> pass the packets directly into the stack using netif_receive_skb()
> and vlan_hwaccel_receive_skb().


Thanks Dave.  I've changed this and also added gro to my net-next
branch.  I will send up this bugfix up for 2.6.29 in a few days.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html