netdev - Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6a2187b0902052139p3be2f321ucd900cc5346bff8c@mail.gmail.com>
Date:	Fri, 6 Feb 2009 13:39:19 +0800
From:	Jeff Chua <jeff.chua.linux@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

On Fri, Feb 6, 2009 at 7:29 AM, David Miller <davem@...emloft.net> wrote:
> [ netdev CC:'d, please always do this for networking stuff ]

Will do.

> Oh well, what is running on each side of the rlogin attempt?

Nothing at all. Just a pure "rlogin remotehost" trying to get a login
prompt. Nothing inside .profile.

On Fri, Feb 6, 2009 at 11:10 AM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> Could you please try a strace on both sides, with and without
> this patch applied?

Attached are two strace. t1.good is a good rlogin run. t4.bad is bad
rlogin run where nothing is displayed but typing "~-." gets back to
the host.

With strace, it takes a bit more try to get it to hang. In fact, this
bug was quite to trigger and I've been having this problem on-and-off
since December, and but it was intermittent and didn't think it was a
kernel problem until serious chasing. Some network switches "mask" out
the problem, and some direct connect always has this problem. Some
servers occurred very frequent, some seldom.

On Fri, Feb 6, 2009 at 7:32 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>  - even just a whiff of "breaks legacy app" just says "revert it".

I agree reverting is the right thing here.

Thanks,
Jeff.

Download attachment "t1.good" of type "application/octet-stream" (14898 bytes)

Download attachment "t4.bad" of type "application/octet-stream" (15008 bytes)