[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090206.015935.60090330.davem@davemloft.net>
Date: Fri, 06 Feb 2009 01:59:35 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: jdb@...x.dk
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] udp: Fix potential wrong ip_hdr(skb) pointers
From: Jesper Dangaard Brouer <jdb@...x.dk>
Date: Fri, 06 Feb 2009 10:55:58 +0100
> On Fri, 2009-02-06 at 01:08 -0800, David Miller wrote:
> > Please respin this patch of your's with proper commit message
> > and signoffs, thanks!
>
> Like the UDP header fix, pskb_may_pull() can potentially
> alter the SKB buffer. Thus the saddr and daddr, pointers
> may point to the old skb->data buffer.
>
> I haven't seen corruptions, as its only seen if the old
> skb->data buffer were reallocated by another user and
> written into very quickly (or poison'd by SLAB debugging).
>
> Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>
Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists