netdev - Re: [PATCH] udp: Fix potential wrong ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090206.031142.42099131.davem@davemloft.net>
Date:	Fri, 06 Feb 2009 03:11:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jdb@...x.dk
Cc:	dada1@...mosbay.com, netdev@...r.kernel.org
Subject: Re: [PATCH] udp: Fix potential wrong ip_hdr(skb) pointers

From: Jesper Dangaard Brouer <jdb@...x.dk>
Date: Fri, 06 Feb 2009 11:49:22 +0100

> On Fri, 2009-02-06 at 11:04 +0100, Eric Dumazet wrote:
> > Jesper Dangaard Brouer a écrit :
> > > On Fri, 2009-02-06 at 01:08 -0800, David Miller wrote:
> > >> Please respin this patch of your's with proper commit message
> > >> and signoffs, thanks!
> > > 
> > > Like the UDP header fix, pskb_may_pull() can potentially
> > > alter the SKB buffer.  Thus the saddr and daddr, pointers
> > > may point to the old skb->data buffer.
> > > 
> > 
> > I dont know... daddr and saddr are not pointers but integers.
> 
> Yes, you are right... its only in the ipv6 code these are pointers
> (which as DaveM mentioned handels it correctly).
> 
> > Patch makes sense as a cleanup, but ChangeLog seems wrong ?
> 
> Okay, lets view it as a cleanup... Its upto DaveM if he wants to fix the
> commit message (or ask me the correct it, revert and reapply...)

I already pushed the commit out, rebasing the tree is not an
option and a revert is super ugly so it's staying as-is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html