netdev - Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 07 Feb 2009 11:23:24 -0500
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	ilpo.jarvinen@...sinki.fi, chuck.lever@...cle.com,
	bfields@...ldses.org, trond@...app.com, linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

On Fri, 2009-02-06 at 19:22 -0800, David Miller wrote:
> From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
> Date: Sat, 7 Feb 2009 00:58:44 +0200 (EET)
> 
> > I think your "English" is too strict requirement.
> 
> I absolutely and whole-heartedly agree.  This set of
> requirements is beyond rediculious and will do nothing
> but deter people from contributing.
> 
> So unless that's what the goal is...
> 
> Anyways, I'll be applying Ilpo's great changes to the
> net-next-2.6 GIT tree, without putting him through the
> ringer like this.

No. I find it quite unacceptable for the networking group to circumvent
the standard Linux review process in this manner. If you plan to push a
patch into the sunrpc code against the wishes of the community and
people that maintain that code then I'll be petitioning Linus to revert
it on general principle as soon as it hits his tree.

Like it or not, the changelog _is_ a part of the patch that is subject
to review and comment, and while I like the rest of the patch, I will
support Chuck and Bruce's comments that putting a bunch of diffstat
output into the changelog is not a substitute for a simple sentence. All
it takes is

"
Save 147 lines by moving the common code from xs_udp_write_space() and
xs_tcp_write_space() into a separate helper.

S-o-b: Ilpo....
"

and everyone will be happy. So please stop making a storm in a teacup
out of this...

Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html