netdev - Re: [PATCH] sctp: chunkmap size is too large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Feb 2009 14:50:19 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	olivier.matz@...nd.com, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, kaber@...filter.org
Subject: Re: [PATCH] sctp: chunkmap size is too large

David Miller wrote:
> From: Olivier MATZ <olivier.matz@...nd.com>
> Date: Fri, 30 Jan 2009 16:43:07 +0100
> 
>> I think that the chunkmap field in struct xt_sctp_info is
>> too large: we have 256 chunk types and it's a bitfield,
>> so the table should be 256 bits (8 uint32_t) instead
>> of 64 uint32_t.
>>
>> I updated the size of the table, and I did some cosmetic
>> changes in SCTP_CHUNKMAP_* macros (use a mask instead of
>> a modulo).
>>
>>   netfilter/xt_sctp.h       |   30 ++++++++++++++++--------------
>>   netfilter_ipv4/ipt_sctp.h |   30 ++++++++++++++++--------------
>>   2 files changed, 32 insertions(+), 28 deletions(-)
>>
>> Can someone have a look at it ? Please CC me for any replies
>> as I'm not on the list.
> 
> Patrick, I assume you got this?

Sorry for the delay. As Jan already noticed, it changes the ABI,
so we change it without adding a new revision. And I don't think
a few bytes of memory savings justify that.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html