netdev - Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090210222802.GN32393@fieldses.org>
Date:	Tue, 10 Feb 2009 17:28:02 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	chuck.lever@...cle.com, trond@...app.com,
	linux-nfs@...r.kernel.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

On Tue, Feb 10, 2009 at 03:20:36PM +0200, Ilpo Järvinen wrote:
> On Sun, 8 Feb 2009, J. Bruce Fields wrote:
> 
> > (Where's diff-func from?)
> 
> My own tool collection. I can make it available if you want to.

Sure, I'd be curious.

--b.

> 
> > In similar cases in the future, if you want to cater to the more tired
> > and/or mentally challenged among us (which may just be me), some clue
> > that visually distinguishes the quoted diff output in the comment might
> > help; e.g., maybe indent it like the below.
> > 
> > (But that's intended as a suggestion, not a requirement.)
> 
> Yeah, a good idea... I'll sed some spaces in front of them in the future 
> to make the difference more obvious. The expected outcome though is that 
> somebody probably then hits reply button too soon claiming that the patch 
> is broken :-).
> 
> 
> -- 
>  i.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html