lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Feb 2009 12:40:16 -0800 From: "Michael Chan" <mchan@...adcom.com> To: "Roel Kluin" <roel.kluin@...il.com> cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Andrew Morton" <akpm@...ux-foundation.org>, mcarlson@...adcom.com Subject: Re: [PATCH] TG3: limit reaches -1 On Wed, 2009-02-11 at 02:49 -0800, Roel Kluin wrote: > With while (limit--) { ... } limit reaches -1, so 0 means success. > > Signed-off-by: Roel Kluin <roel.kluin@...il.com> Acked-by: Michael Chan <mchan@...adcom.com> Thanks. > --- > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > index 8b3f846..4595962 100644 > --- a/drivers/net/tg3.c > +++ b/drivers/net/tg3.c > @@ -852,7 +852,7 @@ static int tg3_bmcr_reset(struct tg3 *tp) > } > udelay(10); > } > - if (limit <= 0) > + if (limit < 0) > return -EBUSY; > > return 0; > @@ -1603,7 +1603,7 @@ static int tg3_wait_macro_done(struct tg3 *tp) > break; > } > } > - if (limit <= 0) > + if (limit < 0) > return -EBUSY; > > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists