netdev - Re: [RFC] netlink broadcast return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49941A89.80606@trash.net>
Date:	Thu, 12 Feb 2009 13:48:09 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Pablo Neira Ayuso <pablo@...filter.org>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFC] netlink broadcast return value

Pablo Neira Ayuso wrote:
> Oh, and also for this:
> 
>> 	if (p->skb2 == NULL) {
>> 		netlink_overrun(sk);
>> 		/* Clone failed. Notify ALL listeners. */
>> 		p->failure = 1;
>                 ^^^^^^^^^^^^^^^
> 
> if (nlk->flags & NETLINK_HIGHLY_RELIABLE)
> 	p->failure = 1;

I always wondered about the intention behind this. It wouldn't
hurt to just try the other allocation and see if they also fail.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html