netdev - Re: [PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Feb 2009 16:58:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yanghy@...fujitsu.com
Cc:	netdev@...r.kernel.org, dhananjay@...xen.com
Subject: Re: [PATCH]netxen:fix compile waring "label
 ‘set_32_bit_mask’ defined but not used" on IA64
 platform

From: Yang Hongyang <yanghy@...fujitsu.com>
Date: Thu, 12 Feb 2009 16:03:51 +0800

> When compile the latest kernel on IA64 platform,I got a warning:
> drivers/net/netxen/netxen_nic_main.c:203: warning: label ‘set_32_bit_mask’ 
> defined but not used
> 
> We do not need label ‘set_32_bit_mask’  on IA64 platform,So move it to #else.
> 
> Signed-off-by: Yang Hongyang<yanghy@...fujitsu.com>

Applied.

Although I think this whole CONFIG_IA64 ifdef business should
be eliminated entirely.  You cannot tell me that we don't
have the generic interfaces necessary to make a proper
decision on dma mask selection in this bit of code.