| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9929d2390902121710q681f7143i16b5c98001279cc1@mail.gmail.com> Date: Thu, 12 Feb 2009 17:10:22 -0800 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: Andre Detsch <adetsch@...ibm.com> Cc: netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net Subject: Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down On Tue, Feb 10, 2009 at 8:35 AM, Andre Detsch <adetsch@...ibm.com> wrote: > > When running ethtool -t on an interface that was just > brought down, the link test was failing. That's because > we need to perform a reset on the interface to be able > to check the link status correctly. There is no problem > on doing such reset right before the test, as the link > test routine is prepared to wait for autoneg to complete > if that is the case. > > Signed-off-by: Andre Detsch <adetsch@...ibm.com> > --- I guess this comes down to what the definition of a Link test should be doing. My $0.02 is that it should be testing if the interface has a link, in which case if you ifdown the interface before running the Link test, I would expect it to fail. With this patch, if you bring down the device and run the ethtool diag tests, the Link test would come back as passing which is something I would not expect. NAK. -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists