netdev - Re: [PATCH] rndis: remove private wrapper of __constant_cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090214.225707.194301286.davem@davemloft.net>
Date:	Sat, 14 Feb 2009 22:57:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	david-b@...bell.net, greg@...ah.com, linville@...driver.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] rndis: remove private wrapper of __constant_cpu_to_le32

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Wed, 11 Feb 2009 14:16:13 -0800

> On Wed, 2009-02-11 at 14:12 -0800, David Brownell wrote:
> > On Wednesday 11 February 2009, Harvey Harrison wrote:
> > > Use cpu_to_le32 directly as it handles constant folding now, replace direct
> > > uses of __constant_cpu_to_{endian} as well.
> > > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > 
> > Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>
> > 
> > ... though I'm trusting you that constant folding really *does* work
> > now, as it didn't when all this code was first written.  Easily enough
> > seen if it doesn't:  build on big-endian HW will break on all the
> > "case cpu_to_le32(constant):" branches.  ;)
> 
> Yes, and large parts of the kernel are already moved to using the base versions
> already.  I fixed the constant-folding bits during the creation/consolidation
> of linux/swab.h

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html