netdev - Re: [PATCH 0/6] mv643xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090215.234630.202443700.davem@davemloft.net>
Date:	Sun, 15 Feb 2009 23:46:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, nico@....org
Subject: Re: [PATCH 0/6] mv643xx_eth updates

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Fri, 13 Feb 2009 01:06:15 +0100

> Two things here:
> - Exporting some functionality that mostly already existed in the
>   driver (interrupt coalescing, etc) to userland via ethtool.
> - Add Kconfig-configurable LRO support.

Applied to net-next-2.6, but I think making LRO support
Kconfig'able is a terrible precedent to set.

We have an ethtool knob, people can turn it off.

And furthermore, if it is worse in some cases that is
a bug that we should fix rather than ignore while hiding
behind some Kconfig option.

Please reconsider...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html