netdev - Re: [PATCH 1/1] net: forcedeth: f55c21fd9a92a444e55ad1ca4e4732d56661bf2e caused wake-on-lan regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Feb 2009 00:13:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ranma+kernel@...edrich.de
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, rjw@...k.pl,
	aabdulla@...dia.com, yhlu.kernel@...il.com, jeff@...zik.org,
	pmhahn@...an.lahn.de
Subject: Re: [PATCH 1/1] net: forcedeth:
 f55c21fd9a92a444e55ad1ca4e4732d56661bf2e caused wake-on-lan regression

From: Tobias Diedrich <ranma+kernel@...edrich.de>
Date: Sat, 14 Feb 2009 16:12:00 +0100

> commit f55c21fd9a92a444e55ad1ca4e4732d56661bf2e, which was
> introduced to fix the regression tracked at
> http://bugzilla.kernel.org/show_bug.cgi?id=11358
> causes the wake-on-lan mac to be reversed in the shutdown path.
> Apparently the forcedeth situation is rather messy in that the mac
> we need to writeback for a subsequent modprobe to work is exactly
> the reverse of what is needed for proper wake-on-lan.
> 
> The following patch explains the situation in the comments and
> makes the call to nv_restore_mac_addr() conditional (only called if
> we are not really going for poweroff).
...
> Signed-off-by: Tobias Diedrich <ranma+kernel@...edrich.de>
> Tested-by: Philipp Matthias Hahn <pmhahn@...an.lahn.de>

Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html