lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Feb 2009 20:20:47 -0600 From: Jay Cliburn <jcliburn@...il.com> To: Hannes Eder <hannes@...neseder.net> Cc: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 13/43] drivers/net/atlx: fix sparse warnings: fix signedness On Sat, 14 Feb 2009 22:15:17 +0100 Hannes Eder <hannes@...neseder.net> wrote: > Impact: While being at it: statics do not need to be initialized with 0. > > Fix this sparse warnings: > drivers/net/atlx/atl1.c:109:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2870:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2880:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2894:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2904:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2913:1: warning: incorrect type in initializer (different signedness) > > Signed-off-by: Hannes Eder <hannes@...neseder.net> Acked-by: Jay Cliburn <jcliburn@...il.com> > --- > drivers/net/atlx/atl1.c | 2 +- > drivers/net/atlx/atl2.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c > index c0ceee0..43fc1b2 100644 > --- a/drivers/net/atlx/atl1.c > +++ b/drivers/net/atlx/atl1.c > @@ -105,7 +105,7 @@ > * Default Value: 100 (200us) > */ > static int __devinitdata int_mod_timer[ATL1_MAX_NIC+1] = ATL1_PARAM_INIT; > -static int num_int_mod_timer; > +static unsigned int num_int_mod_timer; > module_param_array_named(int_mod_timer, int_mod_timer, int, > &num_int_mod_timer, 0); > MODULE_PARM_DESC(int_mod_timer, "Interrupt moderator timer"); > diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c > index bc39449..9fe06c3 100644 > --- a/drivers/net/atlx/atl2.c > +++ b/drivers/net/atlx/atl2.c > @@ -2854,7 +2854,7 @@ static void atl2_force_ps(struct atl2_hw *hw) > #else > #define ATL2_PARAM(X, desc) \ > static int __devinitdata X[ATL2_MAX_NIC+1] = ATL2_PARAM_INIT; \ > - static int num_##X = 0; \ > + static unsigned int num_##X; \ > module_param_array_named(X, X, int, &num_##X, 0); \ > MODULE_PARM_DESC(X, desc); > #endif > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists