netdev - Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090217184349.3c735c58.baranov@mercdev.com>
Date:	Tue, 17 Feb 2009 18:43:49 +0400
From:	Constantin Baranov <baranov@...cdev.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper
 cards

Ben Hutchings <bhutchings@...arflare.com> wrote:
> On Tue, 2009-02-17 at 15:43 +0400, Constantin Baranov wrote:
> > Introduced support for link speed and duplex setting (ethtool -s),
> > link advertising parameters and autonegotiation (ethtool -r):
> [...]
> 
> I haven't looked closely at this, but is there anything here that can't
> be handled by mii_get_settings() and other functions in the mii driver?

mii_ethtool_gset() reports fixed set of supported modes and mii_ethtool_sset()
doesn't check whether requested mode is supported when autonegotiation is
disabled. Also mii module declares mdio_write() operation as returning void,
thus mii routines will ignore errors that may occur. Although all of these is
not so critical I decided not to use mii module.

-- 
Constantin Baranov,
Mercury Development, LLC
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html