netdev - Re: [PATCH 2/3] [kernel] Add support for RX packet classification in a network device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090217.202838.66382200.davem@davemloft.net>
Date:	Tue, 17 Feb 2009 20:28:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Santwona.Behera@....COM
Cc:	netdev@...r.kernel.org, jeff@...zik.org,
	gkernel-commit@...ts.sourceforge.net, Matheos.Worku@....COM,
	Mehdi.Bonyadi@....COM
Subject: Re: [PATCH 2/3] [kernel] Add support for RX packet classification
 in a network device

From: Santwona.Behera@....COM
Date: Mon, 16 Feb 2009 09:17:23 -0800

> -struct ethtool_rxnfc {
> -	__u32		cmd;
> +/* The following structures are for supporting RX network flow
> + * classification configuration. Note, all multibyte fields, e.g.,
> + * ip4src, ip4dst, psrc, pdst, spi, etc. are expected to be in network
> + * byte order.
> + */
> +struct ethtool_tcpip4_spec {
> +	__u32	ip4src;
> +	__u32	ip4dst;
> +	__u16	psrc;
> +	__u16	pdst;
> +	__u8    tos;
> +};

We have specific types for this, "__be32" et al.

Please use them.

And once you do that properly, checking the code with sparse via "make
C=1" will warn for you if these data items are not accessed as
big-endian items.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html