netdev - Re: [PATCH] net: Simplify skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090217.225355.184526778.davem@davemloft.net>
Date:	Tue, 17 Feb 2009 22:53:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Simplify skb_tx_hash()

From: Krishna Kumar <krkumar2@...ibm.com>
Date: Wed, 18 Feb 2009 11:02:11 +0530

> From: Krishna Kumar <krkumar2@...ibm.com>
> 
> The initialization of skb_tx_hashrnd is moved so that it gets called
> after "random" driver is initialized. Random numbers generated at this
> point are different across 3 immediate reboots:
> 	(reboot1) Random number: 0xd52f08b6
> 	(reboot2) Random number: 0x8beeef46
> 	(reboot3) Random number: 0x7d60a4b6
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>

Well, two questions:

1) How in the world are you getting a packet transmitted
   before the random driver initializes?

2) How can an initcall be more random than when the first
   packet is transmitted by the system?

A patch like this needs justification, so in your commit
logs you shouldn't just list out mechanically what your
patch is doing, but rather explain "why".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html