netdev - Re: [PATCH] net: Simplify skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090217.234158.156650176.davem@davemloft.net>
Date:	Tue, 17 Feb 2009 23:41:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Simplify skb_tx_hash()

From: Krishna Kumar2 <krkumar2@...ibm.com>
Date: Wed, 18 Feb 2009 12:57:23 +0530

> > David Miller <davem@...emloft.net>
> > A patch like this needs justification, so in your commit
> > logs you shouldn't just list out mechanically what your
> > patch is doing, but rather explain "why".
> 
> Please let me know if I should give a better text for justification?

Even after reading all of this I still don't understand why
you're making the change.

Is it to eliminate the comparison every packet in skb_tx_hash()?

If so, say that in the commit message so nobody has to
guess.  Saying just "simplify" doesn't express that at all.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html