netdev - Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20090218.175341.142384927.davem@davemloft.net>
Date:	Wed, 18 Feb 2009 17:53:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	baranov@...cdev.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper
 cards

From: Constantin Baranov <baranov@...cdev.com>
Date: Tue, 17 Feb 2009 10:38:52 +0400

> Introduced support for link speed and duplex setting (ethtool -s),
> link advertising parameters and autonegotiation (ethtool -r):
> - struct niu_link_config: split advertising and autoneg
>   fields into active and target values (similar to speed
>   and duplex fields)
> - mii_init_common(): rewrite function to actually apply
>   requested niu_link_config parameters instead of providing
>   default initialization
> - link_status_1g(): move parsing of MII registers into
>   new link_status_mii() function (link_status_1g_rgmii()
>   could possibly use this new implementation too)
> - introduce simple nway_reset method
> - fix incorrect XMAC_CONFIG_MODE selection for 10Mbps case
> 
> Signed-off-by: Constantin Baranov <baranov@...cdev.com>

Looks good, patch applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html