[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <adazlgjz2g0.fsf@cisco.com>
Date: Wed, 18 Feb 2009 16:37:51 -0800
From: Roland Dreier <rdreier@...co.com>
To: Roel Kluin <roel.kluin@...il.com>
Cc: swise@...ngridcomputing.com,
Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] RDMA/cxgb3: logical-/bit-or confusion?
> - ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) | crc_enabled ? 1 : 0;
> + ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) || crc_enabled ? 1 : 0;
> - ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) | crc_enabled ? 1 : 0;
> + ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) || crc_enabled ? 1 : 0;
So as I said before, I guess this change is fine, except:
add/remove: 0/0 grow/shrink: 1/0 up/down: 18/0 (18)
function old new delta
rx_data 1237 1255 +18
ie it makes the object code 18 bytes bigger on x86-64 (gcc 4.3.2).
Given that the code works the same either way, is this change a net win?
- R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists