netdev - [PATCH] iproute2: Fix no default display of ip4ip6 tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <F33E0C3C2876A544ABD34CFBE345A4A40211E426D0@NDMBX01.bbnet.ad>
Date:	Thu, 19 Feb 2009 12:06:33 +0530
From:	"Srivats P" <Srivats.P@...exant.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH] iproute2: Fix no default display of ip4ip6 tunnels

From: Srivats P. <srivats.p@...exant.com>

"ip -6 tunnel show" displays only ip6ip6 tunnels not ip4ip6 tunnels - it should display all irrespective of proto.

This is because the default tunnel proto is initialized to IPPROTO_IPV6 in ip6_tnl_parm_init() which is fine for a 'add' command but not for 'show'. This patch overrides proto with 0 signifying 'mode any' as the default in case of a 'show'.

Signed-off-by: Srivats P. <srivats.p@...exant.com>
---

diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c
index 8421983..0122974 100644
--- a/ip/ip6tunnel.c
+++ b/ip/ip6tunnel.c
@@ -335,6 +335,7 @@ static int do_show(int argc, char **argv)
         struct ip6_tnl_parm p;

        ip6_tnl_parm_init(&p, 0);
+       p.proto = 0;

         if (parse_args(argc, argv, &p) < 0)
                 return -1;

Conexant E-mail Firewall (Conexant.Com) made the following annotations
---------------------------------------------------------------------
********************** Legal Disclaimer **************************** 

"This email may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message in error, please advise the sender by reply email and delete the message. Thank you." 

********************************************************************** 

---------------------------------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html