netdev - Re: [PATCH v2] net/mv643xx: don't disable the mib timer too early and lock properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Feb 2009 17:37:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	sebastian@...akpoint.cc, jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/mv643xx: don't disable the mib timer too early
 and lock properly

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Thu, 19 Feb 2009 02:05:29 +0100

> On Mon, Feb 16, 2009 at 10:28:15PM +0100, Sebastian Andrzej Siewior wrote:
> 
> > mib_counters_update() also restarts the timer.
> > So the timer is dequeued, the stats are read and then the timer is
> > enqueued again. This is "okay" unless someone unloads the module.
> > The locking here is also broken:
> > mib_counters_update() grabs just a simple spinlock. The only thing the
> > lock is good for is to protect the timer func against other callers
> > namely mv643xx_eth_stop() && mv643xx_eth_get_ethtool_stats(). That means
> > if the spinlock is taken via the ethtool path and than the timer kicks
> > in then the box will lock up.
> > 
> > Signed-off-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
> 
> Acked-by: Lennert Buytenhek <buytenh@...vell.com>

Also applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html