netdev - Re: [PATCH 1/3] gre: used time_before for comparing jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090220.000133.175557384.davem@davemloft.net>
Date:	Fri, 20 Feb 2009 00:01:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] gre: used time_before for comparing jiffies

From: Wei Yongjun <yjwei@...fujitsu.com>
Date: Fri, 20 Feb 2009 12:06:44 +0800

> The functions time_before is more robust for comparing
> jiffies against other values.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

There is some history of this in the networking code.

If you inspect carefully, the open-coded versions of
time comparisons in the networking have a larger window
of acceptance.

So actually, it is a regression fo use time_*() helpers
in these cases.

If these things have been like this for so long, it is
very likely there is a good reason :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html