netdev - Re: LRO restructuring?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 20 Feb 2009 08:37:25 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	James Huang <jamesclhuang@...il.com>
Cc:	Jan-Bernd Themann <themann@...ibm.com>,
	Christoph Raisch <raisch@...ibm.com>, netdev@...r.kernel.org
Subject: Re: LRO restructuring?

On Thu, Feb 19, 2009 at 02:17:11PM -0800, James Huang wrote:
> Hi all,
> 
>     One question about inet_lro.c (linux 2.6.28.6)
> In lro_proc_segment(), it does not check the number of available frags
> entries in lro_desc->parent against the number of new fragments to be added
> before calling lro_add_frags().  Is that a bug?  I see that
> lro_proc_segment() does some type of checking at the end, but could that be
> too late (i.e. overflow the frags[])??
> 
>     Also I think some obvious optimization in lro_get_desc() can be done by
> combining the two for loops into one.

That file is obsolete.  The GRO code that will replace it lives
in various places:

	net/core/dev.c
	net/core/skbuff.c
	net/ipv4/af_inet.c
	net/ipv6/af_inet6.c
	net/ipv4/tcp_ipv4.c
	net/ipv6/tcp_ipv6.c
	net/ipv4/tcp.c
	net/8021q/vlan_core.c

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html