netdev - Re: Yet more fixes to etherh.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2009 08:45:58 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	shemminger@...tta.com
Subject: Re: Yet more fixes to etherh.c

On Sun, Feb 22, 2009 at 12:24:14AM -0800, David Miller wrote:
> From: Russell King - ARM Linux <linux@....linux.org.uk>
> Date: Sun, 22 Feb 2009 08:19:47 +0000
> 
> > On Sat, Feb 21, 2009 at 11:44:48PM -0800, David Miller wrote:
> > > From: Russell King - ARM Linux <linux@....linux.org.uk>
> > > Date: Sat, 21 Feb 2009 19:36:33 +0000
> > > 
> > > > Further to a71558d, this is round five of fixes to make etherh work
> > > > again. As mainline kernels stand, the fixes in b9a9b4b were the wrong
> > > > approach.
> > >  ...
> > > > Fix up b9a9b4b by making etherh's net_device_ops refer to the internal
> > > > lib8390 functions, and remove the build of the ISA 8390.c driver.
> > > > 
> > > > Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> > > 
> > > Applied to net-next-2.6, thanks Russell.
> > > 
> > > You mention this as a fix against mainline, but your patch
> > > only applied to net-next-2.6 because the "eth_set_mac_addr"
> > > fix to this driver only exists there.
> > 
> > Hmm, I don't see the problem.  What's currently in mainline is:
> > 
> >         .ndo_set_mac_address    = eth_mac_addr,
> 
> Which didn't go in via the net-2.6 tree, sigh... :-/
> 
> Russell, pick your transport medium, either send ARM network driver
> fixes via me or straight to Linus.
> 
> Not some mixture of both, that's only going to lead to confusion,
> just like it did here.
> 
> I put that "eth_mac_addr" fix into net-next-2.6, and you then sent it
> straight to Linus.

Hmm, so someone else submitted the same fix for that regression caused
by fe96aaa.

Given that the eth_mac_addr change is a regression fix, the question has
to be asked: why is it queued for the next merge window?

In any case, I'm more than willing to push this through the ARM tree, but
at the same time I'm aware that people get upset if they're not copied on
the patches.  That's why I CC'd you with it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html