netdev - RE: [net-next PATCH 1/2] ixgbe: Move ring features into an enum, allowing easier future maintenance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <382A478CAD40FA4FB46605CF81FE39F41F1731EE@orsmsx507.amr.corp.intel.com>
Date:	Tue, 24 Feb 2009 17:26:26 -0800
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [net-next PATCH 1/2] ixgbe: Move ring features into an enum,
 allowing easier future maintenance

>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net] 
>Sent: Tuesday, February 24, 2009 4:37 PM
>To: Kirsher, Jeffrey T
>Cc: netdev@...r.kernel.org; gospo@...hat.com; Waskiewicz Jr, Peter P
>Subject: Re: [net-next PATCH 1/2] ixgbe: Move ring features 
>into an enum, allowing easier future maintenance
>
>From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>Date: Tue, 24 Feb 2009 15:40:37 -0800
>
>> From: Shannon Nelson <shannon.nelson@...el.com>
>> 
>> The ring_feature member of ixgbe_adapter is statically 
>allocated based on
>> the supported features of the device.  When a new feature is 
>added, we need
>> to manually update the static allocation.  This patch makes 
>the feature
>> list an enum, eliminating the need for multiple updates to 
>the code when
>> adding a new feature.
>> 
>> Signed-off-by: Peter P Waskiewicz Jr 
><peter.p.waskiewicz.jr@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>
>Applied.
>
>I would appreciate it if, in the future, Shannon would signoff his
>patches :-)
>

Perhaps a little after the fact, but does this help?  I didn't expect to get credit - they haven't given me credit for my other little tweaks.  Usually I get to remain anonymous...

Signed-off-by: Shannon Nelson <shannon.nelson@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html