netdev - Re: [PATCH 23/26] RDS: Add AF and PF #defines for RDS sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090225.035843.143817933.davem@davemloft.net>
Date:	Wed, 25 Feb 2009 03:58:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	remi.denis-courmont@...ia.com
Cc:	andy.grover@...cle.com, netdev@...r.kernel.org
Subject: Re: [PATCH 23/26] RDS: Add AF and PF #defines for RDS sockets

From: "Rémi Denis-Courmont" <remi.denis-courmont@...ia.com>
Date: Wed, 25 Feb 2009 13:36:36 +0200

> On Wednesday 25 February 2009 09:26:48 ext David Miller, you wrote:
> > From: Andy Grover <andy.grover@...cle.com>
> > Date: Tue, 24 Feb 2009 17:30:40 -0800
> >
> > > @@ -191,7 +191,8 @@ struct ucred {
> > >  #define AF_RXRPC     33      /* RxRPC sockets                */
> > >  #define AF_ISDN              34      /* mISDN sockets                */
> > >  #define AF_PHONET    35      /* Phonet sockets               */
> > > -#define AF_MAX               36      /* For now.. */
> > > +#define AF_RDS               36      /* RDS sockets                  */
> > > +#define AF_MAX               37      /* For now.. */
> > >
> > >  /* Protocol families, same as address families. */
> > >  #define PF_UNSPEC    AF_UNSPEC
> >
> > Pick an unused number, you don't have to increment AF_MAX
> > to allocate a value.
> 
> But that patch is also allocating a PF value and net/socket.c has:

I'm saying to use a lower number, like 21, 27, 28, etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html