netdev - Re: [PATCH] wan: remove some pointless conditionals before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090225154202.GX10622@fi.muni.cz>
Date:	Wed, 25 Feb 2009 16:42:09 +0100
From:	Jan Yenya Kasprzak <kas@...muni.cz>
To:	Wei Yongjun <yjwei@...fujitsu.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] wan: remove some pointless conditionals before kfree_skb()

Wei Yongjun wrote:
: Remove some pointless conditionals before kfree_skb().
: 
: Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

Acked-by: Jan "Yenya" Kasprzak <kas@...muni.cz>

Thanks,

-Yenya

: ---
:  drivers/net/wan/cosa.c |    3 +--
:  1 files changed, 1 insertions(+), 2 deletions(-)
: 
: diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
: index 0d7ba11..d276d72 100644
: --- a/drivers/net/wan/cosa.c
: +++ b/drivers/net/wan/cosa.c
: @@ -731,8 +731,7 @@ static char *cosa_net_setup_rx(struct channel_data *chan, int size)
:  	 * We can safely fall back to non-dma-able memory, because we have
:  	 * the cosa->bouncebuf pre-allocated.
:  	 */
: -	if (chan->rx_skb)
: -		kfree_skb(chan->rx_skb);
: +	kfree_skb(chan->rx_skb);
:  	chan->rx_skb = dev_alloc_skb(size);
:  	if (chan->rx_skb == NULL) {
:  		printk(KERN_NOTICE "%s: Memory squeeze, dropping packet\n",
: -- 
: 1.5.3.8
: 
: 
: 

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog/ |
>>  If you find yourself arguing with Alan Cox, you’re _probably_ wrong.  <<
>>     --James Morris in "How and Why You Should Become a Kernel Hacker"  <<
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html