netdev - Re: [net-next PATCH] igb: remove skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2009 04:14:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	alexander.h.duyck@...el.com, mitch.a.williams@...el.com
Subject: Re: [net-next PATCH] igb: remove skb_orphan calls

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 26 Feb 2009 02:46:23 -0800

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> The skb_orphan call in the tx path has been shown to cause issues as seen
> with the workarounds required for timestamping.
> 
> In order to avoid this it is easiest just to remove the skb_orphan call as
> the motivation for including it was purely performance based, and the
> overall gain from having the call was minimal.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Acked-by: Mitch Williams <mitch.a.williams@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

While I'm happy to apply this, I don't see it as helping the
timestamping situation.

All someone has to do is enable the new timestamping on loopback to
trigger the problem, the loopback MUST orphan SKBs before it pushes
them back into the stack for receive.

Also, Herbert and I have talked about orphaning SKBs even earlier than
dev_queue_xmit()

This post-send timestamping scheme is not going to work, is poorly
designed, and needs to be completely rearchitected.

If it isn't fixed soon, I'll have no choice but to completely revert
all of the timestamping stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html