netdev - Re: [PATCH] sfc: mdio_clause45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1235753117.3164.2.camel@achroite>
Date:	Fri, 27 Feb 2009 16:45:17 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	linux-net-drivers@...arflare.com, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] sfc: mdio_clause45_read errors go unnoticed

On Fri, 2009-02-27 at 17:31 +0100, Roel Kluin wrote:
> This patch was not tested in any way, but:
> 
> since commit 27dd2caca4eabe7c13a052b7456495ba75535e6a
> ------------------------------>8-------------8<---------------------------------
> mdio_clause45_read may return -ERR, but since 'devices' is unsigned, this is not
> noticed.

I already submitted a fix for this.  I do need to resubmit it for
net-next-2.6 though.  Thanks for the reminder.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html