netdev - Re: Marvell 88E609x switch?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090227011903.GS17040@xi.wantstofly.org>
Date:	Fri, 27 Feb 2009 02:19:03 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Gary Thomas <gary@...assoc.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Marvell 88E609x switch?

On Thu, Feb 26, 2009 at 06:12:32PM -0700, Gary Thomas wrote:

> >>>>>> Is there support for this device anywhere?  In particular,
> >>>>>> the M88E6095 switch.
> >>>>> Not at the moment, but it should be easy enough to add.  If your
> >>>>> board already runs on 2.6.28+, I can whip up some patches for you
> >>>>> to try from the docs I have for that part.
> >>>> That would be much appreciated, thanks.
> >>> I noticed that the 6095/6095F are quite similar to the 6131 as far
> >>> as the register set goes.  So something along these lines (hacky
> >>> patch, breaks 6131, not for mainline) might just work to detect
> >>> single 6095s (cascading DSA chips is something that needs more work,
> >>> let's get the single-chip case working first).
> >>>
> >>> The other thing you'll need to do is create dsa platform devices
> >>> for your switch chips, a la how it's done in arch/arm/mach-orion5x/
> >>> or arch/arm/mach-kirkwood/ for example -- you need to pass in a struct
> >>> device * for your network device, a struct device * for your mii bus,
> >>> the switch MII address on the MII bus, and names of the individual
> >>> ports (where you'll specify "cpu" for the port on the switch chip that
> >>> the CPU is connected to).
> >>>
> >>> Let me know if this works.
> >> Thanks, I'll give it a try.  It will take a little effort
> >> to get setup as I have to work within the open firmware
> >> structure (that's how all the various components are
> >> specified).
> > 
> > Right, we don't have OF bindings yet.  I guess this would make sense
> > to do generically at some point, since there are quite a few PPC
> > platforms with DSA switch chips.
> 
> Here's what I tried - (patch attached) - a trulyhorrible hack,
> but I've not figured out how to get the correct device pointers
> from the OF world yet.  The boot log shows that it's trying, but
> I don't see the DSA layer (M88E690x driver) doing the MII indirection
> that's needed for this device.
> 
> I'm probably not starting it up correctly, but I think I followed
> the examples you cited.  Any ideas?

"indirection needed for this device" -- does that mean that your
switch chip is configured to use the multi-chip addressing mode?
(It looks like it, as most of the MII addresses return ffff in
their ID registers.)  If yes, you should set ->sw_addr to whatever
MII address the chip has been assigned.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html