netdev - Re: [PATCH] r8169: read MAC address from EEPROM on init (2nd attempt)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090301223414.GA25537@electric-eye.fr.zoreil.com>
Date:	Sun, 1 Mar 2009 23:34:14 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Ivan Vecera <ivecera@...hat.com>,
	bhutchings@...arflare.com
Subject: Re: [PATCH] r8169: read MAC address from EEPROM on init (2nd
	attempt)

Ivan Vecera <ivecera@...hat.com> :
[...]
> I tested 5 systems each with different Realtek NICs and I didn't find any
> problem. AFAIK Francois's NICs also works fine.

Yes.

[...]
> +	/* read MAC address */
> +	x = rtl_eeprom_read(ioaddr, RTL_EEPROM_MAC_ADDR);
> +	mac[0] = x & 0xff;
> +	mac[1] = x >> 8;
> +	x = rtl_eeprom_read(ioaddr, RTL_EEPROM_MAC_ADDR + 1);
> +	mac[2] = x & 0xff;
> +	mac[3] = x >> 8;
> +	x = rtl_eeprom_read(ioaddr, RTL_EEPROM_MAC_ADDR + 2);
> +	mac[4] = x & 0xff;
> +	mac[5] = x >> 8;

I would not had mind a loop here but it's otherwise fine.

Please apply.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html